Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 9d9a4d20 authored by Ludovic Barman's avatar Ludovic Barman
Browse files

Location Fudger: Gate behind correct flags

Fixes the current warning: `[FlaggedApi] Method getCoarseningLevel() is a flagged API and should be inside an if (Flags.populationDensityProvider()) check`

In practice, calling the method while the flag is disabled should never happen, as "Flags.populationDensityProvider()" should imply that the cache is null (see the code in the Manager). Yet, it seems bad practice to call an API gated behind a flag without checking this flag, so in essence the warning is correct. Thus this commit should remove a potential footgun if the code in the manager changes.

Tests:
- atest FrameworksMockingServicesTests:LocationFudgerTest
- atest FrameworksMockingServicesTests:LocationFudgerCacheTest

Test: manual atest on Pixel 7 pro (see above)
Flag: android.location.flags.density_based_coarse_locations
Bug: 376198890
Change-Id: I8bfd9c6e4f4921d7e6389f2924b6b3566a8ae07f
parent 93df45a0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment