Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cbf98c1 authored by Satish Yalla's avatar Satish Yalla Committed by Android (Google) Code Review
Browse files

Merge "Revert "Show Taskbar before accessing its icons"" into main

parents afacdc49 f6fe3429
Loading
Loading
Loading
Loading
+0 −4
Original line number Diff line number Diff line
@@ -57,13 +57,10 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)
    }

    @Test
    open fun enterSplitScreenByDragFromAllApps() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .openAllApps()
            .getAppIcon(secondaryApp.appName)
@@ -75,6 +72,5 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardown() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }
}
+0 −4
Original line number Diff line number Diff line
@@ -59,13 +59,10 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)
    }

    @Test
    open fun enterSplitScreenByDragFromShortcut() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .getAppIcon(secondaryApp.appName)
            .openDeepShortcutMenu()
@@ -86,7 +83,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardwon() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }

    companion object {
+0 −4
Original line number Diff line number Diff line
@@ -54,8 +54,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)

        tapl.goHome()
        SplitScreenUtils.createShortcutOnHotseatIfNotExist(tapl, secondaryApp.appName)
        primaryApp.launchViaIntent(wmHelper)
@@ -63,7 +61,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

    @Test
    open fun enterSplitScreenByDragFromTaskbar() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .getAppIcon(secondaryApp.appName)
            .dragToSplitscreen(secondaryApp.packageName, primaryApp.packageName)
@@ -74,7 +71,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardown() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }

    companion object {
+0 −8
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ import android.tools.device.flicker.legacy.LegacyFlickerTest
import android.tools.device.flicker.legacy.LegacyFlickerTestFactory
import androidx.test.filters.RequiresDevice
import com.android.wm.shell.flicker.utils.SplitScreenUtils
import org.junit.After
import org.junit.Assume
import org.junit.Before
import org.junit.FixMethodOrder
@@ -43,10 +42,8 @@ abstract class EnterSplitScreenByDragFromAllAppsBenchmark(override val flicker:
            setup {
                tapl.goHome()
                primaryApp.launchViaIntent(wmHelper)
                tapl.enableBlockTimeout(true)
            }
            transitions {
                tapl.showTaskbarIfHidden()
                tapl.launchedAppState.taskbar
                    .openAllApps()
                    .getAppIcon(secondaryApp.appName)
@@ -60,11 +57,6 @@ abstract class EnterSplitScreenByDragFromAllAppsBenchmark(override val flicker:
        Assume.assumeTrue(tapl.isTablet)
    }

    @After
    fun after() {
        tapl.enableBlockTimeout(false)
    }

    companion object {
        @Parameterized.Parameters(name = "{0}")
        @JvmStatic
+0 −8
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ import android.tools.device.flicker.legacy.LegacyFlickerTest
import android.tools.device.flicker.legacy.LegacyFlickerTestFactory
import androidx.test.filters.RequiresDevice
import com.android.wm.shell.flicker.utils.SplitScreenUtils
import org.junit.After
import org.junit.Assume
import org.junit.Before
import org.junit.FixMethodOrder
@@ -43,20 +42,13 @@ abstract class EnterSplitScreenByDragFromShortcutBenchmark(
        Assume.assumeTrue(tapl.isTablet)
    }

    @After
    fun after() {
        tapl.enableBlockTimeout(false)
    }

    protected val thisTransition: FlickerBuilder.() -> Unit = {
        setup {
            tapl.goHome()
            SplitScreenUtils.createShortcutOnHotseatIfNotExist(tapl, secondaryApp.appName)
            primaryApp.launchViaIntent(wmHelper)
            tapl.enableBlockTimeout(true)
        }
        transitions {
            tapl.showTaskbarIfHidden()
            tapl.launchedAppState.taskbar
                .getAppIcon(secondaryApp.appName)
                .openDeepShortcutMenu()
Loading