Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6fe3429 authored by Satish Yalla's avatar Satish Yalla Committed by Android (Google) Code Review
Browse files

Revert "Show Taskbar before accessing its icons"

Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: Ib305cad259ea4705d1d46ffc160e7adc6204763d
parent 773e51a1
Loading
Loading
Loading
Loading
+0 −4
Original line number Diff line number Diff line
@@ -57,13 +57,10 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)
    }

    @Test
    open fun enterSplitScreenByDragFromAllApps() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .openAllApps()
            .getAppIcon(secondaryApp.appName)
@@ -75,6 +72,5 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardown() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }
}
+0 −4
Original line number Diff line number Diff line
@@ -57,13 +57,10 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)
    }

    @Test
    open fun enterSplitScreenByDragFromShortcut() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .getAppIcon(secondaryApp.appName)
            .openDeepShortcutMenu()
@@ -84,6 +81,5 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardwon() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }
}
+0 −4
Original line number Diff line number Diff line
@@ -52,8 +52,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
        tapl.setEnableRotation(true)
        tapl.setExpectedRotation(rotation.value)

        tapl.enableBlockTimeout(true)

        tapl.goHome()
        SplitScreenUtils.createShortcutOnHotseatIfNotExist(tapl, secondaryApp.appName)
        primaryApp.launchViaIntent(wmHelper)
@@ -61,7 +59,6 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {

    @Test
    open fun enterSplitScreenByDragFromTaskbar() {
        tapl.showTaskbarIfHidden()
        tapl.launchedAppState.taskbar
            .getAppIcon(secondaryApp.appName)
            .dragToSplitscreen(secondaryApp.packageName, primaryApp.packageName)
@@ -72,6 +69,5 @@ constructor(val rotation: Rotation = Rotation.ROTATION_0) {
    fun teardown() {
        primaryApp.exit(wmHelper)
        secondaryApp.exit(wmHelper)
        tapl.enableBlockTimeout(false)
    }
}
+0 −8
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ import android.tools.device.flicker.legacy.LegacyFlickerTest
import android.tools.device.flicker.legacy.LegacyFlickerTestFactory
import androidx.test.filters.RequiresDevice
import com.android.wm.shell.flicker.utils.SplitScreenUtils
import org.junit.After
import org.junit.Assume
import org.junit.Before
import org.junit.FixMethodOrder
@@ -43,10 +42,8 @@ abstract class EnterSplitScreenByDragFromAllAppsBenchmark(override val flicker:
            setup {
                tapl.goHome()
                primaryApp.launchViaIntent(wmHelper)
                tapl.enableBlockTimeout(true)
            }
            transitions {
                tapl.showTaskbarIfHidden()
                tapl.launchedAppState.taskbar
                    .openAllApps()
                    .getAppIcon(secondaryApp.appName)
@@ -60,11 +57,6 @@ abstract class EnterSplitScreenByDragFromAllAppsBenchmark(override val flicker:
        Assume.assumeTrue(tapl.isTablet)
    }

    @After
    fun after() {
        tapl.enableBlockTimeout(false)
    }

    companion object {
        @Parameterized.Parameters(name = "{0}")
        @JvmStatic
+0 −8
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ import android.tools.device.flicker.legacy.LegacyFlickerTest
import android.tools.device.flicker.legacy.LegacyFlickerTestFactory
import androidx.test.filters.RequiresDevice
import com.android.wm.shell.flicker.utils.SplitScreenUtils
import org.junit.After
import org.junit.Assume
import org.junit.Before
import org.junit.FixMethodOrder
@@ -43,20 +42,13 @@ abstract class EnterSplitScreenByDragFromShortcutBenchmark(
        Assume.assumeTrue(tapl.isTablet)
    }

    @After
    fun after() {
        tapl.enableBlockTimeout(false)
    }

    protected val thisTransition: FlickerBuilder.() -> Unit = {
        setup {
            tapl.goHome()
            SplitScreenUtils.createShortcutOnHotseatIfNotExist(tapl, secondaryApp.appName)
            primaryApp.launchViaIntent(wmHelper)
            tapl.enableBlockTimeout(true)
        }
        transitions {
            tapl.showTaskbarIfHidden()
            tapl.launchedAppState.taskbar
                .getAppIcon(secondaryApp.appName)
                .openDeepShortcutMenu()
Loading