Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 9083bfdd authored by Matt Garnes's avatar Matt Garnes Committed by Gerrit Code Review
Browse files

Properly clean up when setting new InputFilter.

In f1b93471, the single InputFilter that
is set in InputManagerService was replaced with a chain of filters that
are all listening for InputEvents.

The original field mInputFilter was replaced in this patch but not
removed. When a new InputFilter is added, we check that this unused
field mInputFilter != null before doing necessary teardown of the previous
filter. Since this is always null, this causes the previous filter to
not be disconnected when a new one is set with setInputFilter().

If the user toggles "Magnification Gestures" on and off twice in Accessibility
Settings, this will send the old and new InputFilters into a loop
sending and receiving touch events, locking up the device completely
until reboot.

Remove all references to the unused mInputFilter field.

Change-Id: I6ef67a664f1e783f3f0402b7c2a0984499a4b614
(cherry picked from commit d5aeb074)
parent 6b5530ad
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment