Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 8f6faf79 authored by eray orçunus's avatar eray orçunus Committed by Michael Bestas
Browse files

SystemUI: Enable and fix QS detail view, adapt layout to 11



* Re-enabling dual-target(detail view) was easy as pie, but layout was from Oreo
  and DND tile was broken.

* I've applied QS Customize layout to details view to match it with Pie look.

* DND showDetail function was overriden to show new EnableZenModeDialog.
  New dialog's implementation were taken from old detail view, so I've disabled
  the new one, added the only new thing (priority-but-alarm-disabled warning text)
  to old one and enabled it.

* DND tile will still respect "Ask duration every time" setting and ask duration to
  the user, but this time with detail view.

* Squashes in the follow commits:

Author: Chengzhi.Hou <hcz017@gmail.com>
Date:   Fri May 11 12:26:56 2018 +0800

    SystemUI: Enable dualTarget on CellularTile

    * To show DataUsageDetailView

    Change-Id: If09b4ac51bb6df01b8ea9f59bccf123de65da8cf

Author: LuK1337 <priv.luk@gmail.com>
Date:   Sat Jun 23 13:18:27 2018 +0200

    SystemUI: CellularTile: Don't call showDetail() when device is locked

    * We recently enabled dualTarget for CellularTile which allowed us
      to toggle mobile data without unlocking device. Moving showDetail
      call to postQSRunnableDismissingKeyguard when the device is locked
      fixes this issue.

    Change-Id: I16dc766166a33a309a2fc945e81fa15b5d194196

Author: Paul Keith <javelinanddart@gmail.com>
Date:   Wed Jun 27 18:28:22 2018 +0200

    SystemUI: Fix Data Usage tile to match Settings

    Change-Id: Ieff3504baf3d13c77d06fcde87d5ac56d2586194

Author: eray orçunus <erayorcunus@gmail.com>
Date:   Fri Apr 26 00:15:30 2019 +0300

    SystemUI: Fix several layout bugs

    * QSDetail and QSCustomize panels' clippers starts after the black
      header, but the ripple animation coords were wrong.

    * QSDetail and QSCustomize use a transparent view to let QS header
      be seen. Header's height changes with orientation, but QSDetail
      and QSCustomize do nothing about it.
      As a result, there were gaps or blocked views.

    Change-Id: I5cefad14b519be99adcf5c913e96385d45b8fb17
Signed-off-by: default avatareray orçunus <erayorcunus@gmail.com>

Author: Dan Pasanen <dan.pasanen@gmail.com>
Date:   Wed Nov 6 15:01:32 2019 -0600

    SystemUI: Convert tiles to use UnlockMethodCache#canSkipBouncer

     * This updates the API following commit aaba8ef2.

    Change-Id: I4932a3e023a40e362e81fd74f2921e9cb472ebf3

Author: LuK1337 <priv.luk@gmail.com>
Date:   Fri Aug 23 15:03:32 2019 +0200

    SystemUI: Use matching data usage size formatting between QS and Settings

    * Fixes : https://gitlab.com/LineageOS/issues/android/issues/1102

    Change-Id: Ie80e19de758f599b1fdedb6d991cbdd86e4f2a47

Author: LuK1337 <priv.luk@gmail.com>
Date:   Sun Feb 2 14:23:29 2020 +0100

    SystemUI: Pass correct NetworkTemplate to CellularTile detail view

    Change-Id: Ib41a4086e10ccba71909370549d3714815684b2f

Author: Michael W <baddaemon87@gmail.com>
Date:   Sat Jun 20 16:05:40 2020 +0200

    SystemUI: QS Details: Fix layout issues

    * Remove bottom padding:
      * It shifts the content up unnecessarily
      * It leaves a small white line at the bottom
    * Introduce a new background color for the switch bar: derived from
      textColorPrimary because that is basically the exact opposite of the
      background color so it allows us to get a slightly brighter overlay
    * Also change the qs detail's background: use the same color as for the
      rest of the qs backgrounds - now it doesn't look different from the rest
      anymore (was a slightly darker shade of white on light theme and a
      brighter grey on dark. This was more noticeable on a dark theme and is
      basically also the reason that we noticed the wrong padding
    * For zen tile (dnd), remove all background color references and apply
      qs_background_primary for the whole panel at once. Applying the
      color manually is required because the panel is inflated separately
      and not using the color that is assigned to the original content.
      Removing all separate references allows to define and change the color
      in one place
    * In order to make the buttons also look good on dark background,
      assign a color (similar to the one for the switchbar, see above)
      manually
    * Also remove the min height and add top/bottom paddings so the buttons
      are not as huge as currently
    * Remove start and end padding from QS detail header xml, because they are
      a) a mixture of left and end, which should really be start/end or
         left/right
      b) Not used anymore, as QSDetail.java applies them in
         onApplyWindowInsets programmatically

    The alpha values of 5% and 8% for our newly defined colors were determined
    by trying various values until it looked good on all themes

    Test: Open every qs tile on both light and dark themes and see if
     they look proper

    Change-Id: I5be8bf97582e877bdb1af1f3aedc88c00d134c16

Author: Michael W <baddaemon87@gmail.com>
Date:   Sun Jun 21 17:22:39 2020 +0200

    SystemUI: Fix issue with Bluetooth tile

    * Currently: Pair a device
    * Open BT tile details ("details"), device is shown
    * Disable bt via the switchbar, close the details via the "done" button
    * Reopen the details -> the list is empty, neither "empty" text nor
      actual devices are shown

    After this patch: Reopening the details turns on bt which in turn makes
     devices visible again

    Change-Id: I1a0a5ebdcaca50bc821b0180f2109d00091eaa1c

Author: Bruno Martins <bgcngm@gmail.com>
Date:   Wed Oct 7 23:43:37 2020 +0100
Edit:   CellularTile: Update to Android 11 APIs

Change-Id: Ifebc1b0612f575990f4b86d458de0eb684e01f5a
parent f3bd1ca4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment