Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c79b6a5 authored by Siarhei Vishniakou's avatar Siarhei Vishniakou
Browse files

Prevent some keylayouts from being added to Android

Some of the custom key layouts cause problems. Specifically:

1. Microsoft designed some of its devices to work with Generic.kl, and
if we add a custom layout, it could break these devices. We
should check with Microsoft prior to adding such layouts. Often, we
should just tell the users to update the firmware on their controllers
to get it working properly.

2. Some devices use the same vendor id / product id (incorrectly). They
should all have unique numbers, but they have chosen
to reuse Broadcom's numbers instead. As a result, adding a layout for
one of them breaks the others. Matching by name is fine,
though. Fail the build to prevent these from being added.

Bug: 191720859
Bug: 194334400
Test: added one of these layouts and tried to build Android, observed
build failure

Change-Id: I26c44dd3d322154cc1eeecbc7cab65b1add130d0
parent 2943f54e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment