Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 8821afef authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Preserve invocation order in RemoteInputConnection

This is a follow up CL to our previous CL [1], which introduced
early-exit paths to some RemoteInputConnection methods to protect
innocent IME clients from unexpected process crashes when an IME is
calling InputConnection APIs with invalid parameters.

Although protecting IME clients from crashes still makes much sense,
implementing it as an early-exit style in RemoteInputConnection may
expose observable inconsistency to IME developers in terms of the fact
that InputConnection#getText{Before,After}Cursor() can also work as a
fence operation that would not return until all the previously issued
InputConnection API invocations are handled in the IME client side.

With this CL, the following methods start behaving as a fence
operation even when an invalid parameter is passed, by checking the
parameters in the IME client side.

 * RemoteInputConnection#getTextAfterCursor()
 * RemoteInputConnection#getTextBeforeCursor()
 * RemoteInputConnection#getSurroundingText()

There should be no performance impact for IMEs that do not make such
an invalid (and unnecessary) API calls.

 [1]: I95169735198f8363c981a61e20234dfebfd645b1
      1e72ef28

Bug: 169114026
Fix: 194110780
Test: atest CtsInputMethodTestCases:InputConnectionEndToEndTest
Change-Id: Ie0c18d0c9b8bf8f02f2fcdca5aac7e580c6bf2cd
parent b6d3eecb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment