Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86684240 authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Media process should run with "write" access. 

The WRITE_MEDIA_STORAGE permission had inadvertently been giving apps
the "default" view of storage.  This had worked for a long since,
since we also gave them the "sdcard_rw" permission, but a recent
security patch broke this for secondary users.

Apps holding this permission should have been mounted "write" all
along, and relied on that view to access storage devices.  This also
means they no longer need the "sdcard_rw" GID.

Test: builds, boots, secondary user media/camera works
Bug: 72732906, 71737806, 72224817
Change-Id: I5cd687a1e128024f33b4acd93c15e75192ed1c85
parent 4a740846

data/etc/platform.xml

+0 −1
Original line number Diff line number Diff line
@@ -62,7 +62,6 @@ 


    <permission name="android.permission.WRITE_MEDIA_STORAGE" >

        <group gid="media_rw" />

        <group gid="sdcard_rw" />

    </permission>



    <permission name="android.permission.ACCESS_MTP" >

services/core/java/com/android/server/pm/PackageManagerService.java

+0 −3
Original line number Diff line number Diff line
@@ -20936,9 +20936,6 @@ Slog.v(TAG, ":: stepped forward, applying functor at tag " + parser.getName()); 
                if (Process.isIsolated(uid)) {

                    return Zygote.MOUNT_EXTERNAL_NONE;

                }

                if (checkUidPermission(WRITE_MEDIA_STORAGE, uid) == PERMISSION_GRANTED) {

                    return Zygote.MOUNT_EXTERNAL_DEFAULT;

                }

                if (checkUidPermission(READ_EXTERNAL_STORAGE, uid) == PERMISSION_DENIED) {

                    return Zygote.MOUNT_EXTERNAL_DEFAULT;

                }