Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 85784a4b authored by Daniel Norman's avatar Daniel Norman
Browse files

Replace SetFlagsRule with CheckFlagsRule.

SetFlagsRule is intended for unit tests of completely isolated
unit test methods; while ProxyManagerTest does use mocking in order
to keep its execution environment simpler & assert that certain mocked
methods are executed, it is still an executed as an integration test
that depends on the running state of the device and interacts with
other classes on the device.

CheckFlagsRule is better suited for testing non-isolated methods
because it uses the default value of all flags on the device (it
doesn't change any flags) and instead skips irrelevant tests if
a flag is required to be enabled or disable for a given test.

Bug: 286587811
Test: atest ProxyManagerTest, both with flag disabled & enabled
Change-Id: I615af25b71c5696f11e7901b12948a8fc0d7f79b
parent 28aef0fe
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment