Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 85312718 authored by Mady Mellor's avatar Mady Mellor Committed by Android Build Coastguard Worker
Browse files

Fix how taskview is used by controlsUi

When controlsUi is dismissed, it calls taskview#release, which
should only be done when the task & taskview are done being used
which isn't really the case until the task is explicitly removed.

Since the controlsUi is going away, the taskview surface gets
destroyed which triggers a transition to move its task TO_BACK,
however, because release has been called, we have no reference to
the taskview in TaskViewTransitions, so the TO_BACK transition
falls to the default transition handler which results in the
incorrect animation.

To fix this, instead of calling taskview#release when the controls
ui is being dismissed, call taskview#removeTask to actually remove
the task. In the onTaskRemovalStarted callback, we can then clean
up the taskview.

Test: manual - open controls panel and swipe up to home
             => observe that there isn't a second animation of the
                task animating away
Bug: 282102652
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:96c2b131230db84221c23c07ac4853ed02fc6461)
Merged-In: Ie40d078e4a05d3323a3364b82f6af171ae97181c
Change-Id: Ie40d078e4a05d3323a3364b82f6af171ae97181c
parent 69617f80
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment