Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83c853b2 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove InputMethodManagerDelegate#startInput() 

This is a follow up CL to my previous CL [1], which partly reverted
the initial commit of ImeFocusController [2].

With that CL,

  InputMethodManagerDelegate#startInput()

is no longer called.  Thus we no longer need to defined it.

There must be no behavior change.

 [1]: Ie3446e1d0f62c489195e31fc7f073020884d6cae
      ff975479
 [2]: Ib455704fe1e9d243f93190a84f230210dbceac2a
      970d9d2e

Bug: 234882948
Bug: 244504062
Test: presubmit
Change-Id: I62ae648b75cc33592e4e985b4c975c97ccdd24f8
parent e16dbabf

core/java/android/view/ImeFocusController.java

+0 −9
Original line number Diff line number Diff line
@@ -26,8 +26,6 @@ import android.util.proto.ProtoOutputStream; 
import android.view.inputmethod.InputMethodManager;



import com.android.internal.inputmethod.InputMethodDebug;

import com.android.internal.inputmethod.StartInputFlags;

import com.android.internal.inputmethod.StartInputReason;



/**

 * Responsible for IME focus handling inside {@link ViewRootImpl}.
@@ -189,13 +187,6 @@ public final class ImeFocusController { 
     * @hide

     */

    public interface InputMethodManagerDelegate {

        /**

         * Starts the input connection.

         */

        boolean startInput(@StartInputReason int startInputReason, View focusedView,

                @StartInputFlags int startInputFlags,

                @WindowManager.LayoutParams.SoftInputModeFlags int softInputMode, int windowFlags);



        void onPostWindowFocus(View viewForWindowFocus,

                @NonNull WindowManager.LayoutParams windowAttribute);

        void onViewFocusChanged(@NonNull View view, boolean hasFocus);

core/java/android/view/inputmethod/InputMethodManager.java

+2 −5
Original line number Diff line number Diff line
@@ -737,11 +737,8 @@ public final class InputMethodManager { 


    private final class DelegateImpl implements

            ImeFocusController.InputMethodManagerDelegate {

        /**

         * Used by {@link ImeFocusController} to start input connection.

         */

        @Override

        public boolean startInput(@StartInputReason int startInputReason, View focusedView,



        private boolean startInput(@StartInputReason int startInputReason, View focusedView,

                @StartInputFlags int startInputFlags, @SoftInputModeFlags int softInputMode,

                int windowFlags) {

            ImeTracing.getInstance().triggerClientDump(