Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8273c50a authored by Jorge Gil's avatar Jorge Gil
Browse files

Fix TaskInfo#requestedVisibleTypes update conditions 

1) Force a task info changed dispatch whenever the window's requested
   visible types change, otherwise WMShell window decorations might show
   the wrong UI if it's out of sync with the true window state.
2) Obtain the requested types from top app window *excluding* the
   starting window

Flag: com.android.window.flags.enable_fully_immersive_in_desktop
Fix: 375509830
Test: open Candy Crush in desktop, immersive icon is shown on launch
without having to move the window first to trigger an update

Change-Id: I23eca5da60fcb5f9b167c64be7b8aaa94139a3ba
parent f9f90962

services/core/java/com/android/server/wm/Session.java

+4 −0
Original line number Diff line number Diff line
@@ -706,6 +706,10 @@ class Session extends IWindowSession.Stub implements IBinder.DeathRecipient { 
                win.setRequestedVisibleTypes(requestedVisibleTypes);

                win.getDisplayContent().getInsetsPolicy().onRequestedVisibleTypesChanged(win,

                        imeStatsToken);

                final Task task = win.getTask();

                if (task != null) {

                    task.dispatchTaskInfoChangedIfNeeded(/* forced= */ true);

                }

            } else {

                EmbeddedWindowController.EmbeddedWindow embeddedWindow = null;

                if (android.view.inputmethod.Flags.refactorInsetsController()) {

services/core/java/com/android/server/wm/Task.java

+2 −1
Original line number Diff line number Diff line
@@ -3436,7 +3436,8 @@ class Task extends TaskFragment { 
        info.isSleeping = shouldSleepActivities();

        info.isTopActivityTransparent = top != null && !top.fillsParent();

        info.lastNonFullscreenBounds = topTask.mLastNonFullscreenBounds;

        final WindowState windowState = top != null ? top.findMainWindow() : null;

        final WindowState windowState = top != null

                ? top.findMainWindow(/* includeStartingApp= */ false) : null;

        info.requestedVisibleTypes = (windowState != null && Flags.enableFullyImmersiveInDesktop())

                ? windowState.getRequestedVisibleTypes() : WindowInsets.Type.defaultVisible();

        AppCompatUtils.fillAppCompatTaskInfo(this, info, top);