Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80d00eca authored by TYM Tsai's avatar TYM Tsai
Browse files

Fix the problem of missing signature permissions 

Moving dexopt out of the package freezer so that the installer
executes setUpdatedSystemApp() before notifying the package updated,
that causes the permission service not granting signature
permission again.
To resolve this issue, restore the flag after dexopt and then set it
again after notified the package updated.

Bug: 321139675
Flag: android.content.pm.improve_install_freeze
Test: atest com.google.android.apps.nexuslauncher.imagecomparison.WidgetHomeScreenTest
Test: atest CtsPackageManagerTestCases
Test: atest CtsInstallHostTestCases
Test: atest CtsCompilationTestCases
Change-Id: Ia67fc343f8f5bd2f78dad1110a322106c937c666
parent c1eb4481

services/core/java/com/android/server/pm/DexOptHelper.java

+0 −10
Original line number Diff line number Diff line
@@ -791,16 +791,6 @@ public final class DexOptHelper { 
            }

            try {

                Trace.traceBegin(TRACE_TAG_PACKAGE_MANAGER, "dexopt");



                // This mirrors logic from commitReconciledScanResultLocked, where the library

                // files needed for dexopt are assigned.

                PackageSetting realPkgSetting = installRequest.getRealPackageSetting();

                // Unfortunately, the updated system app flag is only tracked on this

                // PackageSetting

                boolean isUpdatedSystemApp =

                        installRequest.getScannedPackageSetting().isUpdatedSystemApp();

                realPkgSetting.getPkgState().setUpdatedSystemApp(isUpdatedSystemApp);



                DexoptResult dexOptResult = DexOptHelper.dexoptPackageUsingArtService(

                        installRequest, dexoptOptions);

                installRequest.onDexoptFinished(dexOptResult);