Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 805b488c authored by Bishoy Gendy's avatar Bishoy Gendy
Browse files

Revert "Fix security vulnerability allowing apps to start from background" 

This reverts commit 13dd0c48.

Reason for revert: Will make a better fix for the security issue

Change-Id: I4f1669d1d290c423106a41975f3aa8f356f66ee9
parent dd08d28e

services/core/java/com/android/server/media/MediaSessionRecord.java

+6 −12
Original line number Diff line number Diff line
@@ -1457,15 +1457,9 @@ public class MediaSessionRecord extends MediaSessionRecordImpl implements IBinde 


        @Override

        public IBinder getBinderForSetQueue() throws RemoteException {

            return new ParcelableListBinder<QueueItem>(

                    (list) -> {

                        // Checking list items are instanceof QueueItem to validate against

                        // malicious apps calling it directly via reflection with non compilable

                        // items. See b/317048338 for more details

                        List<QueueItem> sanitizedQueue =

                                list.stream().filter(it -> it instanceof QueueItem).toList();

            return new ParcelableListBinder<QueueItem>((list) -> {

                synchronized (mLock) {

                            mQueue = sanitizedQueue;

                    mQueue = list;

                }

                mHandler.post(MessageHandler.MSG_UPDATE_QUEUE);

            });