Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd08d28e authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Reland fixing clock staying in AOD state in LS when transitioning from... 

Merge "Reland fixing clock staying in AOD state in LS when transitioning from bouncer and camera" into main
parents 59b4e61a 20d5e754

packages/SystemUI/src/com/android/keyguard/ClockEventController.kt

+12 −0
Original line number Diff line number Diff line
@@ -431,6 +431,7 @@ constructor( 
                    if (MigrateClocksToBlueprint.isEnabled) {

                        listenForDozeAmountTransition(this)

                        listenForAnyStateToAodTransition(this)

                        listenForAnyStateToLockscreenTransition(this)

                    } else {

                        listenForDozeAmount(this)

                    }
@@ -566,6 +567,17 @@ constructor( 
        }

    }



    @VisibleForTesting

    internal fun listenForAnyStateToLockscreenTransition(scope: CoroutineScope): Job {

        return scope.launch {

            keyguardTransitionInteractor

                    .transitionStepsToState(LOCKSCREEN)

                    .filter { it.transitionState == TransitionState.STARTED }

                    .filter { it.from != AOD }

                    .collect { handleDoze(0f) }

        }

    }



    @VisibleForTesting

    internal fun listenForDozing(scope: CoroutineScope): Job {

        return scope.launch {

packages/SystemUI/tests/src/com/android/keyguard/ClockEventControllerTest.kt

+42 −0
Original line number Diff line number Diff line
@@ -370,6 +370,27 @@ class ClockEventControllerTest : SysuiTestCase() { 
            job.cancel()

        }



    @Test

    fun listenForTransitionToLSFromOccluded_updatesClockDozeAmountToOne() =

        runBlocking(IMMEDIATE) {

            val transitionStep = MutableStateFlow(TransitionStep())

            whenever(keyguardTransitionInteractor.transitionStepsToState(KeyguardState.LOCKSCREEN))

                    .thenReturn(transitionStep)



            val job = underTest.listenForAnyStateToLockscreenTransition(this)

            transitionStep.value =

                    TransitionStep(

                            from = KeyguardState.OCCLUDED,

                            to = KeyguardState.LOCKSCREEN,

                            transitionState = TransitionState.STARTED,

                    )

            yield()



            verify(animations, times(2)).doze(0f)



            job.cancel()

        }



    @Test

    fun listenForTransitionToAodFromLockscreen_neverUpdatesClockDozeAmount() =

        runBlocking(IMMEDIATE) {
@@ -391,6 +412,27 @@ class ClockEventControllerTest : SysuiTestCase() { 
                job.cancel()

            }



    @Test

    fun listenForAnyStateToLockscreenTransition_neverUpdatesClockDozeAmount() =

        runBlocking(IMMEDIATE) {

            val transitionStep = MutableStateFlow(TransitionStep())

            whenever(keyguardTransitionInteractor.transitionStepsToState(KeyguardState.LOCKSCREEN))

                    .thenReturn(transitionStep)



            val job = underTest.listenForAnyStateToLockscreenTransition(this)

            transitionStep.value =

                    TransitionStep(

                            from = KeyguardState.AOD,

                            to = KeyguardState.LOCKSCREEN,

                            transitionState = TransitionState.STARTED,

                    )

            yield()



            verify(animations, never()).doze(0f)



            job.cancel()

        }



    @Test

    fun unregisterListeners_validate() =

        runBlocking(IMMEDIATE) {