Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77dccaf7 authored by Keith Mok's avatar Keith Mok Committed by Gerrit Code Review
Browse files

Disable default blending when drawing color rect 

When drawing a color rectangle (such as drawing the windows background),
the opengl blending mode is always turned on no matter the layer is opaque
or not. This consumes gpu power and memory bandwidth unnecessarily.
The bug was introduced from a refactor of drawColorRect function -
70ca14e0

Change-Id: Ia8996ae0abc1ee9a435d0dc3445809dd45f92b1c
parent 3c6d95fb

libs/hwui/OpenGLRenderer.cpp

+2 −2
Original line number Diff line number Diff line
@@ -3240,7 +3240,7 @@ status_t OpenGLRenderer::drawColorRects(const float* rects, int count, const SkP 
    setupDrawColor(color, ((color >> 24) & 0xFF) * currentSnapshot()->alpha);

    setupDrawShader(getShader(paint));

    setupDrawColorFilter(getColorFilter(paint));

    setupDrawBlending(paint);

    setupDrawBlending(paint, false);

    setupDrawProgram();

    setupDrawDirtyRegionsDisabled();

    setupDrawModelView(kModelViewMode_Translate, false,
@@ -3271,7 +3271,7 @@ void OpenGLRenderer::drawColorRect(float left, float top, float right, float bot 
    setupDrawColor(color, ((color >> 24) & 0xFF) * currentSnapshot()->alpha);

    setupDrawShader(getShader(paint));

    setupDrawColorFilter(getColorFilter(paint));

    setupDrawBlending(paint);

    setupDrawBlending(paint, false);

    setupDrawProgram();

    setupDrawModelView(kModelViewMode_TranslateAndScale, false,

            left, top, right, bottom, ignoreTransform);