Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77a0b4ca authored by Simon Bowden's avatar Simon Bowden
Browse files

Remove bad finalizer from Ringtone. 

This should have moved to LocalRingtonePlayer, but I don't see why the
finalizer is needed at all: the MediaPlayer's finalizer should do its
own thing (orig intro bug 11366759 was about too-eager release).

Bug: 271905784
Test: presubmit
Change-Id: Iff84f413111cf62e727745e84d90579c22666702
parent 85fd8f41

core/api/current.txt

+0 −1
Original line number Diff line number Diff line
@@ -24825,7 +24825,6 @@ package android.media { 
  }















  public class Ringtone {













    method protected void finalize();















    method public android.media.AudioAttributes getAudioAttributes();















    method @Deprecated public int getStreamType();















    method public String getTitle(android.content.Context);

























media/java/android/media/Ringtone.java



+0
−7




























Original line number
Diff line number
Diff line








@@ -542,13 +542,6 @@ public class Ringtone {













        mTitle = title;















    }





























    @Override













    protected void finalize() {













        if (mActivePlayer != null) {













            mActivePlayer.stopAndRelease();













        }













    }





























    /**















     * Play a specific ringtone. This interface is implemented by either local (this process) or















     * proxied-remote playback via AudioManager.getRingtonePlayer, so that the caller