Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ee20ea authored by Dake Gu's avatar Dake Gu
Browse files

Autofill: fix missing focus/ripple effect for authentication view 

When there is authentication view, autofill does not use ListView, so
it's missing the focus/ripple effect. This CL let the parent of
authentication view use the same ripple drawable as ListView.

Test: manual test on phone and TV
      atest CtsAutoFillServiceTestCases
Bug: b/79980365
Change-Id: Ief15304a3e533dbd6f45b7925db0b0c39977fd04
parent f9491caf

core/res/res/layout/autofill_dataset_picker.xml

+1 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
    android:id="@+id/autofill_dataset_picker"

    android:layout_width="fill_parent"

    android:layout_height="fill_parent"

    android:foreground="?attr/listChoiceBackgroundIndicator"

    style="@style/AutofillDatasetPicker">



    <ListView

core/res/res/layout/autofill_dataset_picker_fullscreen.xml

+4 −3
Original line number Diff line number Diff line
@@ -60,12 +60,13 @@ 


    </LinearLayout>



    <!-- autofill_container is the common parent for inserting authentication item or

         autofill_dataset_list, autofill_dataset_foolter-->

    <!-- autofill_dataset_picker is the common parent for inserting authentication item or

         autofill_dataset_list, autofill_dataset_footer-->

    <LinearLayout

        android:layout_width="304dp"

        android:layout_height="wrap_content"

        android:id="@+id/autofill_dataset_picker"

        android:foreground="?attr/listChoiceBackgroundIndicator"

        android:orientation="vertical">

        <ListView

            android:id="@+id/autofill_dataset_list"

core/res/res/layout/autofill_dataset_picker_header_footer.xml

+1 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
    android:id="@+id/autofill_dataset_picker"

    android:layout_width="fill_parent"

    android:layout_height="fill_parent"

    android:foreground="?attr/listChoiceBackgroundIndicator"

    style="@style/AutofillDatasetPicker">



    <LinearLayout

services/autofill/java/com/android/server/autofill/ui/FillUi.java

+2 −2
Original line number Diff line number Diff line
@@ -228,8 +228,8 @@ final class FillUi { 
                mWindow = null;

                return;

            }

            decor.setFocusable(true);

            decor.setOnClickListener(v -> mCallback.onResponsePicked(response));

            container.setFocusable(true);

            container.setOnClickListener(v -> mCallback.onResponsePicked(response));



            if (!mFullScreen) {

                final Point maxSize = mTempPoint;