Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 765f2521 authored by Austin Borger's avatar Austin Borger
Browse files

UidObserverController: Fix incorrect usage of binarySearch return value 

Arrays.binarySearch does not return -1 in all cases where the value
cannot be found. It returns a negative index indicating where the value
would be inserted. This was discovered through additional unit testing
on master.

Bug: 274486653
Test: --
  -- atest UidObserverControllerTest (with new tests)
  -- atest CtsCameraTestCases (CameraEvictionTest)
Change-Id: Ifbb7eab343279c74b53d00a3c64cd6236edcad02
parent ab9ab096

services/core/java/com/android/server/am/UidObserverController.java

+1 −1
Original line number Diff line number Diff line
@@ -557,7 +557,7 @@ public class UidObserverController { 
                return true;

            }



            return Arrays.binarySearch(mUids, uid) != -1;

            return Arrays.binarySearch(mUids, uid) >= 0;

        }



        void addUid(int uid) {