Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75a80fe2 authored by Alejandro Nijamkin's avatar Alejandro Nijamkin Committed by Ale Nijamkin
Browse files

[flexiglass] suspend fun activate now returns Nothing 

This will help catch issues at compile/IDE time where developers can
write unreachable code if they put it after a call to a super.activate()
which suspends forever.

Bug: 354270224
Test: smoke test - ran Flexiglass, moved through all scenes
Flag: com.android.systemui.scene_container
Change-Id: I2b2d0bc8e141d2e8cbd218098339975b6fecf48e
parent 4bdb79bc

packages/SystemUI/compose/features/src/com/android/systemui/bouncer/ui/composable/BouncerScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ constructor( 
    override val destinationScenes: Flow<Map<UserAction, UserActionResult>> =

        actionsViewModel.actions



    override suspend fun activate() {

    override suspend fun activate(): Nothing {

        actionsViewModel.activate()

    }

packages/SystemUI/compose/features/src/com/android/systemui/keyguard/ui/composable/LockscreenScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ constructor( 
    override val destinationScenes: Flow<Map<UserAction, UserActionResult>> =

        actionsViewModel.actions



    override suspend fun activate() {

    override suspend fun activate(): Nothing {

        actionsViewModel.activate()

    }

packages/SystemUI/compose/features/src/com/android/systemui/notifications/ui/composable/NotificationsShadeScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ constructor( 
    override val destinationScenes: Flow<Map<UserAction, UserActionResult>> =

        actionsViewModel.actions



    override suspend fun activate() {

    override suspend fun activate(): Nothing {

        actionsViewModel.activate()

    }

packages/SystemUI/compose/features/src/com/android/systemui/qs/ui/composable/QuickSettingsScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ constructor( 
    override val destinationScenes: Flow<Map<UserAction, UserActionResult>> =

        actionsViewModel.actions



    override suspend fun activate() {

    override suspend fun activate(): Nothing {

        actionsViewModel.activate()

    }

packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/GoneScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ constructor( 
    override val destinationScenes: Flow<Map<UserAction, UserActionResult>> =

        actionsViewModel.actions



    override suspend fun activate() {

    override suspend fun activate(): Nothing {

        actionsViewModel.activate()

    }