Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7209deed authored by John Reck's avatar John Reck
Browse files

Delete dead code 

Bug: 22378829

Every time setText is called a BoringLayout is created.
BoringLayout internally creates a new Paint called mWorkPaint.

However, creating a Paint turns out to be somewhat substantial
amount of work, and mWorkPaint is never actually used. Deleting
this shaves off roughly 50ms and 1,000 object creations during
a fling on a listview.

Change-Id: I5d03402b9027df6ce0f3e58160752c66c69a4d2d
parent adebbeba

core/java/android/text/Layout.java

+0 −2
Original line number Original line Diff line number Diff line
@@ -206,7 +206,6 @@ public abstract class Layout { 




        mText = text;

        mText = text;

        mPaint = paint;

        mPaint = paint;

        mWorkPaint = new TextPaint();

        mWidth = width;

        mWidth = width;

        mAlignment = align;

        mAlignment = align;

        mSpacingMult = spacingMult;

        mSpacingMult = spacingMult;
@@ -1993,7 +1992,6 @@ public abstract class Layout { 




    private CharSequence mText;

    private CharSequence mText;

    private TextPaint mPaint;

    private TextPaint mPaint;

    /* package */ TextPaint mWorkPaint;

    private int mWidth;

    private int mWidth;

    private Alignment mAlignment = Alignment.ALIGN_NORMAL;

    private Alignment mAlignment = Alignment.ALIGN_NORMAL;

    private float mSpacingMult;

    private float mSpacingMult;