Remove Modifier transformations (1/2)
This CL removes the ModifierTransformation interface. This interface was only implement by PunchHole, which is now replaced by Modifier.punchHole that can be called directly from user code. There were 2 main reasons for this removal, which are both performance reasons: - This removes the modifierTransformations() chain applied in http://shortn/_9vgJ2a7Yx6. With this removed and once b/311132415 is fixed, we will be able to make Modifier.element() be a single ModifierNodeElement. - modifierTransformations() was reading the current transition state in http://shortn/_EAjP93YKeQ, which means that *all elements* always recompose whenever the transition state has changed, just because of that PunchHole transformation. Test: PunchHoleTest Test: Manual, in the gallery app by going from Lockscreen <=> Shade Bug: 291071158 Flag: NA Change-Id: I45e71dce8acb98318ac61127bd5294f0a7053dda
Loading
Please register or sign in to comment