Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 71a0448a authored by shreerag@google.com's avatar shreerag@google.com Committed by Sijie Chen
Browse files

Round Scrollbar Upstreaming

See go/wear-1pg-round-scrollbar for information. This CL combined
required changes. It changes the appearance and behavior for the round
scrollbar.

However, for b/245630378, we removed the `awakenScrollBars` call in
current CL, will need a follow up fix for this.

Bug: 270230722
Bug: 272533794,272531770,272530409,272532028
Test: Flashed to the real device, and check the scrollbar:
Looks to me that:
* Padding of the round scrollbar is equal for all edges.
* Scrollbar hits the edge seems doesn't blink anymore and small size
  changes doesn't see the resizing happened.
* Changed RTL language:
adb shell "setprop persist.sys.locale ar-EG; setprop ctl.restart zygote"
Scrollbar now in the left side.

====Squashed original changes as below====

Update round scrollbar for Wear 3

- Add padding to screen edge
- Shorten track length
- Increase thumb size
- Increase track + thumb width
- Change thumb color

Bug: 184897984
Test: scrollbar looks correct
(cherry picked from commit a8652472a25c8ff0ece9b2dd7a904f0b998ff2e4)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:26ac2ca4e4464e4d656f1a5839144e744c50e5e8)
Change-Id: Ifb50d8ff32054c9e74e06f54ba450d1550550a35

Change padding of RoundScrollbar

The padding of the Round Scrollbar was not
calculated correct. It had no padding on the
right side. Now it has equal padding for all
edges and it has been decreased to 2 dp

hsv: https://hsv.googleplex.com/5460495499788288

Test: Manual
Bug: 24677692
Change-Id: Ice486ccb9a518cb61276c8e8a7bcefbd2da9e633

Mirror round scrollbar for RTL languages

Draw the round scrollbar at the left side of the screen
for RTL languages.

hsv: https://hsv.googleplex.com/6278870866067456

Bug: 245698689
Test: Manual
Change-Id: Ia4a9216343d38e58c7984e7b290b1141efa59e92
(cherry picked from commit 862509db05b248037e628b05f3a45514f68bf26a)

Make round scrollbar size changes smooth

Bug: 245630378
Test: Manual

Change-Id: Id0db4b90e403e489ccfddf2013589fd0ff941ae6

Do not resize round scrollbar smoothly for small size changes

Test: Manual
Bug: 254594161
Change-Id: I4e64112125b4004e28ce11ecb5997b8b255737f9

Remove scrollbar blink

The scrollbar sometimes blinks when hitting the edge.
It basically does not draw one frame.

Test: Manual
Bug: 253081897
Change-Id: Ia0846a41687be7b53fcee32a18a6b46e381ffa60
parent 9e7409d8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment