Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a3ad1a1 authored by Justin Weir's avatar Justin Weir
Browse files

Disable blur forcing shade window to be visible 

ag/10672056 added a check for a non-zero blur radius in the logic
that determines whether the window should be visible. We believe
that the check is not required for the new implementation of blur
and that a race condition that only occurs on emulated devices
is causing tests to flake due to non-zero blur being set on an
invisible shade, which makes it become visible and steal input
events.

Bug: 394977231
Flag: com.android.systemui.disable_shade_visible_with_blur
Test: manually checked shade CUJs
Change-Id: Ie433a4378fea6ccc81f942a50b1eb71ee14cf763
parent c0669619

packages/SystemUI/src/com/android/systemui/shade/NotificationShadeWindowControllerImpl.java

+3 −2
Original line number Diff line number Diff line
@@ -498,17 +498,18 @@ public class NotificationShadeWindowControllerImpl implements NotificationShadeW 
    }



    private boolean isExpanded(NotificationShadeWindowState state) {

        boolean visForBlur = !Flags.disableShadeVisibleWithBlur() && state.backgroundBlurRadius > 0;

        boolean isExpanded = !state.forceWindowCollapsed && (state.isKeyguardShowingAndNotOccluded()

                || state.panelVisible || state.keyguardFadingAway || state.bouncerShowing

                || state.headsUpNotificationShowing

                || state.scrimsVisibility != ScrimController.TRANSPARENT)

                || state.backgroundBlurRadius > 0

                || visForBlur

                || state.launchingActivityFromNotification;

        mLogger.logIsExpanded(isExpanded, state.forceWindowCollapsed,

                state.isKeyguardShowingAndNotOccluded(), state.panelVisible,

                state.keyguardFadingAway, state.bouncerShowing, state.headsUpNotificationShowing,

                state.scrimsVisibility != ScrimController.TRANSPARENT,

                state.backgroundBlurRadius > 0, state.launchingActivityFromNotification);

                visForBlur, state.launchingActivityFromNotification);

        return isExpanded;

    }