Commit 649acab3 authored Dec 12, 2014 by minho.choo

Fix bugs regarding delay the dispatching of non-wakeup alarms



checkAllowNonWakeupDelayLocked() method determines that delay the dispatching of non-wakeup alarms.
(there are no wakeup alarms and the screen is off, it can delay until the future.)

if there is any pending non-wakeup alarms, non-wakeup alarm delivery time is bigger than nowELAPSED.
but, checkAllowNonWakeupDelayLocked() returns false and non-wakeup alarm is not delay until future.

i think it is necessary to reverse the inequality symbol on "mNextNonWakeupDeliveryTime > nowELAPSED"
if it isn't, Could you let me know when we get ¡°stuck in a loop¡± in the comment of checkAllowNonWakeupDelayLocked () method?

Change-Id: I7e972064547f4d0a9b4175dbd4cf735b4837abfd
Signed-off-by: Minho Choo <minho.choo@lge.com>

parent 4c23a0ec

services/core/java/com/android/server/AlarmManagerService.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -1587,7 +1587,7 @@ class AlarmManagerService extends SystemService {
		if (mLastAlarmDeliveryTime <= 0) {
		return false;
		}
		if (mPendingNonWakeupAlarms.size() > 0 && mNextNonWakeupDeliveryTime > nowELAPSED) {
		if (mPendingNonWakeupAlarms.size() > 0 && mNextNonWakeupDeliveryTime < nowELAPSED) {
		// This is just a little paranoia, if somehow we have pending non-wakeup alarms
		// and the next delivery time is in the past, then just deliver them all. This
		// avoids bugs where we get stuck in a loop trying to poll for alarms.