Commit 62cdb7bc authored Aug 15, 2025 by Riddle Hsu

Do not apply start transaction by letterbox transition observer

Otherwise the animation may be flickering because the transition
handler has not yet set the initial setup to start transaction.

The transition handler is responsible to apply the start transaction,
so remove the apply which is called from observer.

Bug: 438851781
Flag: com.android.window.flags.app_compat_refactoring
Test: Cold launch an app with
      LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES.
      Rotate the device to landscape.
      No flickering before the rotation animation starts.
Change-Id: I0b7d4b0404c898ce15bd5b62cc45010e1afb3c98

parent 431671f1

libs/WindowManager/Shell/src/com/android/wm/shell/compatui/letterbox/LetterboxInputSurfaceBuilder.kt

+0 −1

Original line number	Diff line number	Diff line
		@@ -46,6 +46,5 @@ constructor(private val surfaceBuilderSupplier: SurfaceBuilderSupplier) {
		tx.setLayer(this, TaskConstants.TASK_CHILD_SHELL_LAYER_LETTERBOX_SPY)
		.setTrustedOverlay(this, true)
		.show(this)
		.apply()
		}
		}