Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60204b63 authored by Songchun Fan's avatar Songchun Fan
Browse files

[SettingsProvider] move handler to background thread 

SettingsRegistry's handler takes care of notifying settings changes to
listeners as well as scheduling jobs. Previously it runs on the main
looper of SettingsProvider, which is effectively on the main thread of
SystemServer because SettingsProvider shares the same process as
SystemServer. Its tasks can be blocking which can block the main thread
of SystemServer. Moving the handler to a background thread instead.

BUG: 319046998
Test: presubmit

Change-Id: I68f022437d1180fdb41d1472524b7e2c277703cb
parent f8a66757

packages/SettingsProvider/src/com/android/providers/settings/SettingsProvider.java

+3 −3
Original line number Diff line number Diff line
@@ -406,7 +406,7 @@ public class SettingsProvider extends ContentProvider { 
                    Process.THREAD_PRIORITY_BACKGROUND);

            mHandlerThread.start();

            mHandler = new Handler(mHandlerThread.getLooper());

            mSettingsRegistry = new SettingsRegistry();

            mSettingsRegistry = new SettingsRegistry(mHandlerThread.getLooper());

        }

        SettingsState.cacheSystemPackageNamesAndSystemSignature(getContext());

        synchronized (mLock) {
@@ -2876,8 +2876,8 @@ public class SettingsProvider extends ContentProvider { 


        private String mSettingsCreationBuildId;



        public SettingsRegistry() {

            mHandler = new MyHandler(getContext().getMainLooper());

        SettingsRegistry(Looper looper) {

            mHandler = new MyHandler(looper);

            mGenerationRegistry = new GenerationRegistry(UserManager.getMaxSupportedUsers());

            mBackupManager = new BackupManager(getContext());

        }