Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ff4de58 authored by Winson Chiu's avatar Winson Chiu
Browse files

Do not hold InstantAppRegistry lock when deleting package 

This looks to be a refactor mistake. The lock doesn't need to be
taken in order to call into DeletePackageHelper.

Bug: 246714055

Test: presubmit

Change-Id: Ia7d0f89083de3a19a84faaca849f9acde8f4a632
parent 44c0ac96

services/core/java/com/android/server/pm/InstantAppRegistry.java

+12 −12
Original line number Diff line number Diff line
@@ -879,7 +879,6 @@ public class InstantAppRegistry implements Watchable, Snappable { 
            });

        }



        synchronized (mLock) {

        if (packagesToDelete != null) {

            final int packageCount = packagesToDelete.size();

            for (int i = 0; i < packageCount; i++) {
@@ -895,6 +894,7 @@ public class InstantAppRegistry implements Watchable, Snappable { 
            }

        }



        synchronized (mLock) {

            // Prune uninstalled instant apps

            // TODO: Track last used time for uninstalled instant apps for better pruning

            for (int userId : mUserManager.getUserIds()) {