Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f137933 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Enrich JavaDoc for IC#deleteSurroundingText(). 

As a preparation work for Bug 6526420, where we are going to
introduce a new variant of IC#deleteSurroundingText(), this CL attempts
to clarify about the expected behavior of IC#deleteSurroundingText().

With this CL, the expected behavior when the number of existing
characters is smaller than the number of characters to be deleted is
now documented by simply describing the current behavior of
BaseInputConnection, that is, IC#deleteSurroundingText() will delete
characters until it deletes requested number of characters in code units
or reaches to an end.

This is purely documentation work.  No behavior change is intended.

Bug: 6526420
Change-Id: I7280dec07e1c043bd26b3b12fd866b9d8b6186cc
parent e8ff81c1

core/java/android/view/inputmethod/BaseInputConnection.java

+14 −7
Original line number Diff line number Diff line
@@ -201,10 +201,17 @@ public class BaseInputConnection implements InputConnection { 
    }



    /**

     * The default implementation performs the deletion around the current

     * selection position of the editable text.

     * @param beforeLength

     * @param afterLength

     * The default implementation performs the deletion around the current selection position of the

     * editable text.

     *

     * @param beforeLength The number of characters before the cursor to be deleted, in code unit.

     *        If this is greater than the number of existing characters between the beginning of the

     *        text and the cursor, then this method does not fail but deletes all the characters in

     *        that range.

     * @param afterLength The number of characters after the cursor to be deleted, in code unit.

     *        If this is greater than the number of existing characters between the cursor and

     *        the end of the text, then this method does not fail but deletes all the characters in

     *        that range.

     */

    public boolean deleteSurroundingText(int beforeLength, int afterLength) {

        if (DEBUG) Log.v(TAG, "deleteSurroundingText " + beforeLength

core/java/android/view/inputmethod/InputConnection.java

+9 −6
Original line number Diff line number Diff line
@@ -335,12 +335,15 @@ public interface InputConnection { 
     * but be careful to wait until the batch edit is over if one is

     * in progress.</p>

     *

     * @param beforeLength The number of characters to be deleted before the

     *        current cursor position.

     * @param afterLength The number of characters to be deleted after the

     *        current cursor position.

     * @return true on success, false if the input connection is no longer

     * valid.

     * @param beforeLength The number of characters before the cursor to be deleted, in code unit.

     *        If this is greater than the number of existing characters between the beginning of the

     *        text and the cursor, then this method does not fail but deletes all the characters in

     *        that range.

     * @param afterLength The number of characters after the cursor to be deleted, in code unit.

     *        If this is greater than the number of existing characters between the cursor and

     *        the end of the text, then this method does not fail but deletes all the characters in

     *        that range.

     * @return true on success, false if the input connection is no longer valid.

     */

    public boolean deleteSurroundingText(int beforeLength, int afterLength);