Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 5d8fead1 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Enable users to dismiss keyboard by long-pressing down button

This is a follow up CL to my CL [1], which basically forked

  com.android.systemui.navigationbar.buttons.KeyButtonView

for IMEs.

In the previous implementation, the user could not dismiss the
keyboard by long-pressing the down button.  To address this issue, the
behavior around long-pressing the donw button is changed as follows.

* Before: on long-pressing the down button,
 - KeyEvent.ACTION_DOWN with FLAG_LONG_PRESS is not sent ot the IME.
 - AccessibilityEvent.TYPE_VIEW_LONG_CLICKED is issued.
 - KeyEvent.ACTION_UP is not sent to the IME.

* After: on long-pressing the down button,
 - KeyEvent.ACTION_DOWN with FLAG_LONG_PRESS is not sent ot the IME.
 - AccessibilityEvent.TYPE_VIEW_LONG_CLICKED is not issued.
 - KeyEvent.ACTION_UP is sent to the IME on releasing long-press.

As there is no known usage of long-pressing the down button, not
sending AccessibilityEvent.TYPE_VIEW_LONG_CLICKED should be OK here.

 [1]: I3e7e1f83554444131e2765dc159617bb9e2337c7
      ff7b453c

Bug: 215443343
Fix: 245555619
Test: Manually verified on aosp_bluejay-userdebug
Change-Id: Ib32f8b610197ab57e45b4e5932d5376ddc59c574
parent e1ad3405
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment