Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c0f472d authored by Jinsuk Kim's avatar Jinsuk Kim
Browse files

CEC: Add missing protections for some HdmiControlService API - DO NOT MERGE

A few methods are found to be missing protection with system permission.
Add enforceAccessPermission() like other methods.

Bug: 17408780

Change-Id: I58a336b5cc9df2d195bdfe7b928898dde5ff169f
(cherry picked from commit b22d9ee0)
parent 7b4a38b1
Loading
Loading
Loading
Loading
+6 −0
Original line number Diff line number Diff line
@@ -1025,6 +1025,7 @@ public final class HdmiControlService extends SystemService {

        @Override
        public HdmiDeviceInfo getActiveSource() {
            enforceAccessPermission();
            HdmiCecLocalDeviceTv tv = tv();
            if (tv == null) {
                Slog.w(TAG, "Local tv device not available");
@@ -1344,11 +1345,13 @@ public final class HdmiControlService extends SystemService {

        @Override
        public void setHdmiRecordListener(IHdmiRecordListener listener) {
            enforceAccessPermission();
            HdmiControlService.this.setHdmiRecordListener(listener);
        }

        @Override
        public void startOneTouchRecord(final int recorderAddress, final byte[] recordSource) {
            enforceAccessPermission();
            runOnServiceThread(new Runnable() {
                @Override
                public void run() {
@@ -1363,6 +1366,7 @@ public final class HdmiControlService extends SystemService {

        @Override
        public void stopOneTouchRecord(final int recorderAddress) {
            enforceAccessPermission();
            runOnServiceThread(new Runnable() {
                @Override
                public void run() {
@@ -1378,6 +1382,7 @@ public final class HdmiControlService extends SystemService {
        @Override
        public void startTimerRecording(final int recorderAddress, final int sourceType,
                final byte[] recordSource) {
            enforceAccessPermission();
            runOnServiceThread(new Runnable() {
                @Override
                public void run() {
@@ -1393,6 +1398,7 @@ public final class HdmiControlService extends SystemService {
        @Override
        public void clearTimerRecording(final int recorderAddress, final int sourceType,
                final byte[] recordSource) {
            enforceAccessPermission();
            runOnServiceThread(new Runnable() {
                @Override
                public void run() {