Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b22d9ee0 authored by Jinsuk Kim's avatar Jinsuk Kim
Browse files

CEC: Add missing protections for some HdmiControlService API 

A few methods are found to be missing protection with system permission.
Add enforceAccessPermission() like other methods.

Bug: 17408780

Change-Id: I58a336b5cc9df2d195bdfe7b928898dde5ff169f
parent ffcdb679

services/core/java/com/android/server/hdmi/HdmiControlService.java

+6 −0
Original line number Diff line number Diff line
@@ -1019,6 +1019,7 @@ public final class HdmiControlService extends SystemService { 


        @Override

        public HdmiDeviceInfo getActiveSource() {

            enforceAccessPermission();

            HdmiCecLocalDeviceTv tv = tv();

            if (tv == null) {

                Slog.w(TAG, "Local tv device not available");
@@ -1338,11 +1339,13 @@ public final class HdmiControlService extends SystemService { 


        @Override

        public void setHdmiRecordListener(IHdmiRecordListener listener) {

            enforceAccessPermission();

            HdmiControlService.this.setHdmiRecordListener(listener);

        }



        @Override

        public void startOneTouchRecord(final int recorderAddress, final byte[] recordSource) {

            enforceAccessPermission();

            runOnServiceThread(new Runnable() {

                @Override

                public void run() {
@@ -1357,6 +1360,7 @@ public final class HdmiControlService extends SystemService { 


        @Override

        public void stopOneTouchRecord(final int recorderAddress) {

            enforceAccessPermission();

            runOnServiceThread(new Runnable() {

                @Override

                public void run() {
@@ -1372,6 +1376,7 @@ public final class HdmiControlService extends SystemService { 
        @Override

        public void startTimerRecording(final int recorderAddress, final int sourceType,

                final byte[] recordSource) {

            enforceAccessPermission();

            runOnServiceThread(new Runnable() {

                @Override

                public void run() {
@@ -1387,6 +1392,7 @@ public final class HdmiControlService extends SystemService { 
        @Override

        public void clearTimerRecording(final int recorderAddress, final int sourceType,

                final byte[] recordSource) {

            enforceAccessPermission();

            runOnServiceThread(new Runnable() {

                @Override

                public void run() {