Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52622668 authored by John Reck's avatar John Reck
Browse files

Use resize, not reserve 

Reserve ensures the underlying buffer is the correct size, but
iterating across it is not necessarily valid. Use resize() instead
to ensure that the iterator access is valid

Change-Id: I35ff5f4416bb94cf4ce2c6acf72ffd17ab3e523a
parent 406c51b3

libs/hwui/RenderNode.cpp

+1 −1
Original line number Diff line number Diff line
@@ -119,7 +119,7 @@ void RenderNode::pushStagingChanges(TreeInfo& info) { 
        mProperties = mStagingProperties;

    }

    if (mNeedsAnimatorsSync) {

        mAnimators.reserve(mStagingAnimators.size());

        mAnimators.resize(mStagingAnimators.size());

        std::vector< sp<RenderPropertyAnimator> >::iterator it;

        // hint: this means copy_if_not()

        it = std::remove_copy_if(mStagingAnimators.begin(), mStagingAnimators.end(),