Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 511a3186 authored by Neil Fuller's avatar Neil Fuller
Browse files

Enable geolocation-based time zone detection

Enable the geolocation-based time zone detection feature by default.

This changes the main feature switch from "off" to "on". Previously, the
feature was only on if the
"persist.sys.location_time_zone_detection_feature_enabled" system
property was set to "1".

The impact of this config change for the "average" device is that it
adds a new system service (LocationTimeZoneManagerService), which on a
properly configured device (i.e. ones with LocationTimeZoneProviders
configured) also binds the providers' services during server start up.

The SettingsUI is also affected: when the feature is enabled, currently
there is an extra menu item added in the Date & Time settings to allow
the user to enable location-based time zone detection.  i.e. this commit
enables users to turn on the behavior if they wish.

The setting is off by default, meaning that telephony-based tz detection
will still be used for users unless they explicitly turn on the feature.
Then, the user must also have their "location enabled" toggle on, and
possibly also the "Google Location Accuracy" setting to get good
results. The SettingsUI is not finalized but this means testers can
easily start using the feature and providing early feedback.

If this commit is reverted, users that did enable location-based time
zone detation will no longer see the setting. Devices will revert to
telephony-based tz detection, even for users that have turned it on, as
the user's setting is ignored when the feature is off.

Bug: 172546738
Test: build / boot
Change-Id: Ic5dfcd2ab4e0ec73ba0c9f03208c916313a6702d
parent 0131f69b
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1603,7 +1603,7 @@
    <integer name="config_timeZoneRulesCheckRetryCount">5</integer>

    <!-- Whether the geolocation time zone detection feature is enabled. -->
    <bool name="config_enableGeolocationTimeZoneDetection" translatable="false">false</bool>
    <bool name="config_enableGeolocationTimeZoneDetection" translatable="false">true</bool>

    <!-- Whether to enable primary location time zone provider overlay which allows the primary
         location time zone provider to be replaced by an app at run-time. When disabled, only the