Commit 4fbe95ed authored Feb 09, 2012 by John Grossman

Fix a segfault in AudioFlinger.



Check the string returned by a HAL's implementation of get_parameters
for NULL before attempting to make use of it.  That way, we won't
bring down the mediaserver because of a poorly written HAL.

Change-Id: Ic99d7b004520d7d6347842a681c0595e889b68ea
Signed-off-by: John Grossman <johngro@google.com>

parent 3540a019

services/audioflinger/AudioFlinger.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -906,7 +906,7 @@ String8 AudioFlinger::getParameters(audio_io_handle_t ioHandle, const String8& k
		for (size_t i = 0; i < mAudioHwDevs.size(); i++) {
		audio_hw_device_t *dev = mAudioHwDevs[i];
		char *s = dev->get_parameters(dev, keys.string());
		out_s8 += String8(s);
		out_s8 += String8(s ? s : "");
		free(s);
		}
		return out_s8;