Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 4f1cd284 authored by Ats Jenk's avatar Ats Jenk
Browse files

Check if protolog group can log to logcat

After a refactor to ProtoLog tool in ag/26215014 and ag/26255566
KtProtoLog was not able to log any messages to Logcat.
Regardless of whether the group had logging enabled or not.
Issue was with relying on the ProtoLog class which is updated during
codegen phase.
Kotlin class is not able to use the code generated class and falls back
to the stub.
Did try converting the KtProtoLog.kt to java. In this case KtProtoLog
gets processed and updated during protolog compilation phase. But Kotlin
classes calling KtProtoLog still seem to call into the stub Java
implementation.
Updating the KtProtoLog class to check from the ProtoLogGroups directly
if logging to logcat is enabled.

Bug: 276432490
Test: disable logging desktop logs to logcat by default (group
  WM_SHELL_DESKTOP_MODE),
  build and run sysui, check that desktop logs are not present in
  logcat,
  enable shell protolog group WM_SHELL_DESKTOP_MODE,
  observe that logs are present
Change-Id: Iac18bfc9e0aeccb41648a6b208ebbd57fd11454a
parent af8f1ceb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment