Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 4c7719d3 authored by Thomas Makin's avatar Thomas Makin
Browse files

CEC: correct frameworks physicalAddress parsing



The HIDL interface defines physical address as a uint16_t, but Java
does not utilize unsigned types, so it represents this value as a
standard 32-bit signed integer type. However, it extends the MSB to
the full 32-bits instead of padding with zeroes, causing large
values to be read as negative, crashing the service when
HdmiPortInfo builder asserts >=0.

This also clarifies a related comment likely sourced from the same
incorrect assumption about how the parsing behaves.

Co-authored-by: default avatarThomas Makin <halorocker89@gmail.com>
Co-authored-by: default avatarAaron Kling <webgeek1234@gmail.com>

Change-Id: If101cf5a725315d75ea5315d4cf42c8d55fb7bec
parent 582ed2b2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment