Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4b415605 authored by Alejandro Nijamkin's avatar Alejandro Nijamkin
Browse files

[flexiglass] Fixes crashloop. 

The crashloop is a Dagger runtime dependency cycle that was introduced
in ag/28088831 and was missed because that CL didn't test with
Flexiglass on (it concerned itself only with clocks in the legacy
code).

The problem is that the change removed the inherent "laziness" that the
sampleFilter provided and caused the upstream
keyguardTransitionInteractor.transitionValue to be collected eagerly, as
soon as the KeyguardInteractor was instantiated.

Test: manually verified that the crash doesn't occur anymore when
flexiglass is on, also that there's no crashloop when flexiglass is off
Flag: com.android.systemui.scene_container
Fix: 350495724

Change-Id: I99533a0baec0d4f8bd5a2268b6139005069c625f
parent e386be21

packages/SystemUI/src/com/android/systemui/keyguard/domain/interactor/KeyguardInteractor.kt

+2 −1
Original line number Diff line number Diff line
@@ -249,7 +249,7 @@ constructor( 
    val isKeyguardGoingAway: Flow<Boolean> = repository.isKeyguardGoingAway



    /** Keyguard can be clipped at the top as the shade is dragged */

    val topClippingBounds: Flow<Int?> =

    val topClippingBounds: Flow<Int?> by lazy {

        combineTransform(

                keyguardTransitionInteractor

                    .transitionValue(scene = Scenes.Gone, stateWithoutSceneContainer = GONE)
@@ -263,6 +263,7 @@ constructor( 
                }

            }

            .distinctUntilChanged()

    }



    /** Last point that [KeyguardRootView] view was tapped */

    val lastRootViewTapPosition: Flow<Point?> = repository.lastRootViewTapPosition.asStateFlow()