Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 46d13cce authored by Mathew Inwood's avatar Mathew Inwood
Browse files

Fail early if we fail to parse frameworks-res.apk.

If we fail to parse this APK, there will be no mapping for "android" in
mPackages, resulting in NUllPointerException's later during boot in code
that reasonably assumes that it is present. This may result in some poor
sap wasting days trying to diagnose a trivial error in the frameworks
manifest file, trying to spot the single warning earier in the log that
caused the problem.

Instead, fail early, so that the relevant warning in the log will be just
before the exception, rather then several pages back.

Test: Make a change to core/res/AndroidManifest.xml that results in
Test: the parser failing, and verify that it throws here rather then
Test: later. Verified that it does *not* throw here when everything
Test: is ok.

Change-Id: I4d0c5e935e1e29ad70566808783045f33dbc1114
parent 757fb482
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment