Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f7c4a3c authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Check MissingMethodFlags.COMMIT_CORRECTION at the right place 

This is a follow up CL to my previous CL [1], which aimed to put an
early-exit check for

  InputConnection#commitCorrection(CorrectionInfo)

but mistakenly put it in

  InputConnection#commitCompletion(CompletionInfo).

With this CL the early-exit check will be placed at the right place.

 [1]: I3c58fadd924fad72cb984f0c23d3099fd0295c64
      19a80a1e

Fix: 193907158
Test: atest CtsInputMethodTestCases:InputConnectionEndToEndTest
Change-Id: I497628165072c73d0e279f89afe0d8730531ecfc
parent c577086e

core/java/android/inputmethodservice/RemoteInputConnection.java

+4 −4
Original line number Diff line number Diff line
@@ -247,15 +247,15 @@ final class RemoteInputConnection implements InputConnection { 


    @AnyThread

    public boolean commitCompletion(CompletionInfo text) {

        if (isMethodMissing(MissingMethodFlags.COMMIT_CORRECTION)) {

            // This method is not implemented.

            return false;

        }

        return mInvoker.commitCompletion(text);

    }



    @AnyThread

    public boolean commitCorrection(CorrectionInfo correctionInfo) {

        if (isMethodMissing(MissingMethodFlags.COMMIT_CORRECTION)) {

            // This method is not implemented.

            return false;

        }

        return mInvoker.commitCorrection(correctionInfo);

    }