Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 3f3c6244 authored by Steve Elliott's avatar Steve Elliott
Browse files

Remove Controller usage from NotificationShelf

Under a unidirectional architecture, Views should not have access to
their Controller

- AmbientState is View-related logic, so NotificationShelf can access
that information directly on mAmbientState instead of going through the
controller.

- NotificationShelfController needs to push the KeyguardBypassController
state into NotificationShelf, in order to reverse the data flow

  - Rather than NotificationShelf having a concept of "Bypass", change
  the API to "setCanModifyColorOfNotifications" (as opposed to
  "setBypassEnabled", for example)

Bug: 271161129
Test: atest SystemUITests
Change-Id: I1c1615d5c3b28e2237f77b786b4dad062ffbea37
parent 6d5c413a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment