Commit 3ed19276 authored Aug 28, 2013 by Alexander Toresson Committed by Johan Redestig Jan 23, 2014

Fix for positioning of glyphs within a bitmap

For positioning of glyphs within a bitmap, roundf(int + float) is used,
where the float is the glyph position and the int is the text position.
When the text position is varied, this may lead to the sum being rounded
in different directions, due to floating point rounding, caused by that
floating point numbers have different precision in different ranges.

This may therefore lead to slightly different positioning for glyphs and
therefore slightly different widths and heights for text strings,
depending on the position they are rendered at.

The solution in this patch is to use int + (int) roundf(float), which
has consistent rounding, and also enables us to use the full range of
ints.

Change-Id: Id1143cdfcbdfa9915ced878ae04df589a3e03cee

parent c9a60b0f

libs/hwui/font/Font.cpp

+3 −3

Original line number	Diff line number	Diff line
		@@ -404,10 +404,10 @@ void Font::render(SkPaint* paint, const char* text, uint32_t start, uint32_t len
		// If it's still not valid, we couldn't cache it, so we shouldn't
		// draw garbage; also skip empty glyphs (spaces)
		if (cachedGlyph->mIsValid && cachedGlyph->mCacheTexture) {
		float penX = x + positions[(glyphsCount << 1)];
		float penY = y + positions[(glyphsCount << 1) + 1];
		int penX = x + (int) roundf(positions[(glyphsCount << 1)]);
		int penY = y + (int) roundf(positions[(glyphsCount << 1) + 1]);

		(this.render)(cachedGlyph, roundf(penX), roundf(penY),
		(this.render)(cachedGlyph, penX, penY,
		bitmap, bitmapW, bitmapH, bounds, positions);
		}