Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e2a2326 authored by Riddle Hsu's avatar Riddle Hsu
Browse files

Invoke setColorSpaceAgnostic only when needed 

The default value is false, so it only needs to be called when the
flag is set. This avoids frequent extra IPC in performTraversals.

Also use async apply because it doesn't have order dependency
with other operation.

Bug: 308662081
Flag: com.android.window.flags.set_sc_properties_in_client
Test: Add trace around setColorSpaceAgnostic.
      It is only called for a few cases.
Change-Id: I28a21ce92e2d01ecbe3cdfd7d628228f2d66c7c6
parent 55cba851

core/java/android/view/ViewRootImpl.java

+10 −2
Original line number Diff line number Diff line
@@ -996,6 +996,7 @@ public final class ViewRootImpl implements ViewParent, 
    private final ImeFocusController mImeFocusController;















    private boolean mIsSurfaceOpaque;













    private boolean mIsSurfaceColorSpaceAgnostic;





























    private final BackgroundBlurDrawable.Aggregator mBlurRegionAggregator =















            new BackgroundBlurDrawable.Aggregator(this);










@@ -3858,12 +3859,19 @@ public final class ViewRootImpl implements ViewParent,













                    }





























                    if (setScPropertiesInClient()) {













                        if (surfaceControlChanged) {













                            // Reset to default for a new SurfaceControl.













                            mIsSurfaceColorSpaceAgnostic = false;













                        }















                        if (surfaceControlChanged || windowAttributesChanged) {















                            boolean colorSpaceAgnostic = (lp.privateFlags















                                    & WindowManager.LayoutParams.PRIVATE_FLAG_COLOR_SPACE_AGNOSTIC)















                                    != 0;













                            mTransaction.setColorSpaceAgnostic(mSurfaceControl, colorSpaceAgnostic)













                                    .apply();













                            if (colorSpaceAgnostic != mIsSurfaceColorSpaceAgnostic) {













                                mIsSurfaceColorSpaceAgnostic = colorSpaceAgnostic;













                                mTransaction.setColorSpaceAgnostic(













                                        mSurfaceControl, colorSpaceAgnostic).applyAsyncUnsafe();













                            }















                        }















                    }















                }