Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 387f519e authored by Evan Rosky's avatar Evan Rosky
Browse files

Don't try to dequeue while shell transitions disabled 

When systemui crashes, the transition system needs to
clean-up all pending/queued transitions. It seems that
some of the clean-up logic is "re-entrant" if the queue
is deep. This meant we were sometimes calling into
logic that acted as-if we weren't cleaning-up. So add
a check there.

Bug: 439829314
Test: N/A, this only happens during sysui crash -- watch crash trends
Flag: EXEMPT bugfix
Change-Id: I2ec9a76def7a1c77a0619d8810c5ecabc5da64f0
parent 5efa5630

services/core/java/com/android/server/wm/TransitionController.java

+1 −0
Original line number Diff line number Diff line
@@ -1188,6 +1188,7 @@ class TransitionController { 
    }



    void tryStartCollectFromQueue() {

        if (!isShellTransitionsEnabled()) return;

        if (mQueuedTransitions.isEmpty()) return;

        // Only need to try the next one since, even when transition can collect in parallel,

        // they still need to serialize on readiness.