Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3509b624 authored by Eric Holk's avatar Eric Holk
Browse files

Remove obtainStyledAttribute and AssetManager2::GetBag tracing 

These traces are small and noisy, so they hurt performance more than they help.

This reverts commit c3745779.

Test: m
Bug: 132721345
Change-Id: I9ef719f54f2bc8a54f23e88f46d74e35417a6519
parent 30edf328

core/java/android/content/res/ResourcesImpl.java

+2 −5
Original line number Diff line number Diff line
@@ -1390,11 +1390,9 @@ public class ResourcesImpl { 
                @StyleableRes int[] attrs,

                @AttrRes int defStyleAttr,

                @StyleRes int defStyleRes) {

            Trace.traceBegin(Trace.TRACE_TAG_RESOURCES, "obtainStyledAttributes");

            TypedArray array;

            synchronized (mKey) {

                final int len = attrs.length;

                array = TypedArray.obtain(wrapper.getResources(), len);

                final TypedArray array = TypedArray.obtain(wrapper.getResources(), len);



                // XXX note that for now we only work with compiled XML files.

                // To support generic XML files we will need to manually parse
@@ -1405,10 +1403,9 @@ public class ResourcesImpl { 
                        array.mDataAddress, array.mIndicesAddress);

                array.mTheme = wrapper;

                array.mXml = parser;

            }

            Trace.traceEnd(Trace.TRACE_TAG_RESOURCES);

                return array;

            }

        }



        @NonNull

        TypedArray resolveAttributes(@NonNull Resources.Theme wrapper,

libs/androidfw/AssetManager2.cpp

+0 −2
Original line number Diff line number Diff line
@@ -778,8 +778,6 @@ const ResolvedBag* AssetManager2::GetBag(uint32_t resid) { 
}



const ResolvedBag* AssetManager2::GetBag(uint32_t resid, std::vector<uint32_t>& child_resids) {

  ATRACE_NAME("AssetManager::GetBag");



  auto cached_iter = cached_bags_.find(resid);

  if (cached_iter != cached_bags_.end()) {

    return cached_iter->second.get();