Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3745779 authored by Eric Holk's avatar Eric Holk
Browse files

Add more tracing for obtainStyledAttributes 

Much of the time for View inflation is spent in calls to
obtainStyledAttributes. This change adds more granular tracing of this method so
we can better attribute how inflation time is spent.

Test: manual - looked at systrace for starting an app.

Change-Id: Ib72aef1e8b788ce5a61ba13b57bb4417a263b48c
parent 8ab61fb0

core/java/android/content/res/ResourcesImpl.java

+5 −2
Original line number Diff line number Diff line
@@ -1343,9 +1343,11 @@ public class ResourcesImpl { 
                @StyleableRes int[] attrs,

                @AttrRes int defStyleAttr,

                @StyleRes int defStyleRes) {

            Trace.traceBegin(Trace.TRACE_TAG_RESOURCES, "obtainStyledAttributes");

            TypedArray array;

            synchronized (mKey) {

                final int len = attrs.length;

                final TypedArray array = TypedArray.obtain(wrapper.getResources(), len);

                array = TypedArray.obtain(wrapper.getResources(), len);



                // XXX note that for now we only work with compiled XML files.

                // To support generic XML files we will need to manually parse
@@ -1356,8 +1358,9 @@ public class ResourcesImpl { 
                        array.mDataAddress, array.mIndicesAddress);

                array.mTheme = wrapper;

                array.mXml = parser;

                return array;

            }

            Trace.traceEnd(Trace.TRACE_TAG_RESOURCES);

            return array;

        }



        @NonNull