Fix Configuration layout direction comparison.
If the Configuration layout direction is not changing don't indicate that it has changed. When the indication is made incorrectly it causes the window manager to believe that the configuration has changed and it will start freezing the screen and setting up animations. Bad jank is the result. In Configuration.updateFrom() anytime that the screenLayouts were different the code was setting ActivityInfo.CONFIG_LAYOUT_DIRECTION in the return bitmask. Even if the only difference was between UNDEFINED fields. This fix makes sure that the layout direction field has actually changed before setting ActivityInfo.CONFIG_LAYOUT_DIRECTION in the return bitmask. In Configuration.diff() if the passed Configuration had SCREENLAYOUT_LAYOUTDIR_UNDEFINED the code was setting ActivityInfo.CONFIG_LAYOUT_DIRECTION in the return bitmask. This fix makes sure that if the passed Configuration has fields set to SCREENLAYOUT_*_UNDEFINED then corresponding bits will no longer be set in the returned bitmask. Fixes bug 10291622. Fixes bug 10247094. Change-Id: If26de662206fe85dc4671adbae39dfb99dc1038c
Loading
Please register or sign in to comment