Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3045bbaf authored by Vasu Nori's avatar Vasu Nori
Browse files

bug:3330569 print better message to help debug the problem 

methods such as SQLiteStatement.simpleQueryForString() expect
one and only row to be returned when the query is executed.
if the application provides a query that doesn't return any data,
then the error message printed is pretty confusing.

make it less confusing and print the query itself to help debug
the error.

Change-Id: Ife2066f3a3eab0b98845a49e8f72b518458a7757
parent 817b3f93

core/java/android/database/sqlite/SQLiteStatement.java

+12 −0
Original line number Diff line number Diff line
@@ -131,6 +131,10 @@ public class SQLiteStatement extends SQLiteProgram 
            long retValue = native_1x1_long();

            mDatabase.logTimeStat(mSql, timeStart);

            return retValue;

        } catch (SQLiteDoneException e) {

            throw new SQLiteDoneException(

                    "expected 1 row from this query but query returned no data. check the query: " +

                    mSql);

        } finally {

            releaseAndUnlock();

        }
@@ -150,6 +154,10 @@ public class SQLiteStatement extends SQLiteProgram 
            String retValue = native_1x1_string();

            mDatabase.logTimeStat(mSql, timeStart);

            return retValue;

        } catch (SQLiteDoneException e) {

            throw new SQLiteDoneException(

                    "expected 1 row from this query but query returned no data. check the query: " +

                    mSql);

        } finally {

            releaseAndUnlock();

        }
@@ -172,6 +180,10 @@ public class SQLiteStatement extends SQLiteProgram 
        } catch (IOException ex) {

            Log.e(TAG, "simpleQueryForBlobFileDescriptor() failed", ex);

            return null;

        } catch (SQLiteDoneException e) {

            throw new SQLiteDoneException(

                    "expected 1 row from this query but query returned no data. check the query: " +

                    mSql);

        } finally {

            releaseAndUnlock();

        }