Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d007421 authored by Eliot Courtney's avatar Eliot Courtney
Browse files

Make sure to set-up listener last in NonPhoneDependencyTest.

It turns out that when the listener is added, a notification could come
in, and then call one of the managers that wasn't set up yet, causing an
NPE. This led to some flaky presubmits.

Bug: 72648842
Test: none
Change-Id: I250e916246ba7ce8aa356e941ad2b5551303c472
parent 12048341
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -86,13 +86,13 @@ public class NonPhoneDependencyTest extends SysuiTestCase {
                mHeadsUpManager);
        gutsManager.setUpWithPresenter(mPresenter, entryManager, mListContainer,
                mCheckSaveListener, mOnClickListener);
        notificationListener.setUpWithPresenter(mPresenter, entryManager);
        notificationLogger.setUpWithEntryManager(entryManager, mListContainer);
        mediaManager.setUpWithPresenter(mPresenter, entryManager);
        remoteInputManager.setUpWithPresenter(mPresenter, entryManager, mRemoteInputManagerCallback,
                mDelegate);
        lockscreenUserManager.setUpWithPresenter(mPresenter, entryManager);
        viewHierarchyManager.setUpWithPresenter(mPresenter, entryManager, mListContainer);
        notificationListener.setUpWithPresenter(mPresenter, entryManager);

        assertFalse(mDependency.hasInstantiatedDependency(StatusBarWindowManager.class));
    }