Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 2a9dd990 authored by axfordjc's avatar axfordjc
Browse files

Refactor of LargeScreenUtils.shouldUseLargeScreenShadeHeader

Primary reason for refactor is to include flagging - so split shade on small landscape screens can be flag-guarded.

Refactor:
- removed static methods LargeScreenUtils.shouldUseLargeScreenShadeHeader
- now using SplitShadeStateController.shouldUseSplitNotificationShade
- SplitShadeStateController is injected or passed when necessary
- flag guarding can now be done in SplitShadeStateController.shouldUseSplitNotificationShade
- FakeSplitShadeStateController is passed in test classes

Improvements that could be made in a follow up CL:
- no longer need resources as a parameter for shouldUseLargeScreenShadeHeader, context can be injected and then context.resources could be used internally
- StateFlow could be used, this could be subscribed to instead of checking shouldUseLargeScreenShadeHeader in 'updateResources' methods.
- Improvements ignored for now to reduce the size of the change and speed up review

Now, when LOCKSCREEN_ENABLE_LANDSCAPE is on: split shade is used on small landscape screens.

Bug: 293252410

Test: See files
Change-Id: If35ad6d5e095f15e037b0d2bb58f346758966379
parent 60485875
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment